[PATCH] D24242: [Coroutines] Part13: Handle single edge PHINodes across suspends

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: lib/Transforms/Coroutines/CoroEarly.cpp:163-168
@@ -162,8 +162,8 @@
   }
   return Changed;
 }
 
 //===----------------------------------------------------------------------===//
 //                              Top Level Driver
 //===----------------------------------------------------------------------===//
 
----------------
GorNishanov wrote:
> After I took out the fixup code, I am having second thoughts on it and want to put it back.
> 
> CoroEarly purpose is to cleanup after frontend. The fixup for coro.frees fits nicely there. Having nearly identical code that looks like LLVM pass at the end of CodeGenFunction::FinishFunction seems awkward. Having it in CoroEarly puts all of the cleanup logic in one place.
Ok, let's bring it back.


https://reviews.llvm.org/D24242