[PATCH] D24362: Pass CVRecords through visitors as non-const references

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 14:50:01 PDT 2016


zturner added a comment.

In https://reviews.llvm.org/D24362#537664, @rnk wrote:

> lgtm While you're at it, it would be good if we could kill off Data and RawData, they're pretty redundant. Probably worth a separate change.


I tried, but it's not that easy.  I still want to think about how to do that some more.  The problem is that for top level records, `Data = RawData.drop_front(sizeof(RecordPrefix))`, but for field list member records, they're equal.


https://reviews.llvm.org/D24362





More information about the llvm-commits mailing list