[PATCH] D24363: [ELF] Fix DT_NEEDED value

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 13:53:02 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/InputFiles.cpp:481
@@ -479,3 +480,3 @@
   this->initStringTable();
-  SoName = this->getName();
+  SoName = sys::path::filename(this->getName());
 
----------------
Stripping path parts from the default seems fine, but

================
Comment at: ELF/InputFiles.cpp:494
@@ -492,3 +493,3 @@
         fatal(getFilename(this) + ": invalid DT_SONAME entry");
-      SoName = StringRef(this->StringTable.data() + Val);
+      SoName = sys::path::filename(StringRef(this->StringTable.data() + Val));
       return;
----------------
we should respect DT_SONAME value, no?


https://reviews.llvm.org/D24363





More information about the llvm-commits mailing list