[PATCH] D24356: ELF: accept -m elf_amd64 as an alias for -m elf_x86_64

Ed Maste via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 12:28:22 PDT 2016


emaste added inline comments.

================
Comment at: test/ELF/emulation.s:32-34
@@ -1,4 +31,5 @@
+
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %tx64
 # RUN: ld.lld -m elf_x86_64 %tx64 -o %t2x64
 # RUN: llvm-readobj -file-headers %t2x64 | FileCheck --check-prefix=X86-64 %s
 # RUN: ld.lld %tx64 -o %t3x64
----------------
ruiu wrote:
> Instead of adding "AMD64:" lines, can you reuse exiting "X86-64"? I think the output will be the same.
It's not completely identical -- note the OS/ABI. Right now I could probably change the `triple=x86_64-unknown-freebsd` to `-triple=x86_64-unknown-linux` and switch to `elf_amd64` from `elf_amd64_fbsd`, and then reuse the `X86-64` lines.

However, as the amd64 case is somewhat FreeBSD-specific I'd prefer to leave the FreeBSDisms in this test case and leave it as `elf_amd64_fbsd`.



https://reviews.llvm.org/D24356





More information about the llvm-commits mailing list