[PATCH] D23875: Ease dealing with tagged enum ErrorDescription with some macros.

Filipe Cabecinhas via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 11:34:39 PDT 2016


It will save much more after the other errors are reified. Putting it in
now avoids writing all that mechanical code which we know we will delete.

All the Report* functions (one per error) will have a structure to describe
that error. Now there are 4 of those. Later they will be around 12 (don't
have the code handy right now).

Thank you,

 Filipe

On Thursday, 8 September 2016, Vitaly Buka <vitalybuka at google.com> wrote:

> vitalybuka added a comment.
>
> It saves 9 line of code, but makes it less readable.
> I strongly prefer existing code.
>
>
> https://reviews.llvm.org/D23875
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160908/c1e91008/attachment.html>


More information about the llvm-commits mailing list