[PATCH] D24337: Fix the Thumb test for vfloat intrinsics

Pablo Barrio via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 10:20:52 PDT 2016


pbarrio added a comment.

The changes to the vfloatintrinsics tests are independent from the functional change to add ".code 32", although I discovered them while working on this bug. I will close this review, and create a separate one with the test changes only.

What you say about .code directives makes sense to me, specially about making sure that the assembler interprets the directives correctly. I anticipated some discussion but I didn't know there was already a conversation about this.


https://reviews.llvm.org/D24337





More information about the llvm-commits mailing list