[PATCH] D24338: [InlineCost] Remove CallPenalty and change MinSizeThreshold to 5

[Mehdi AMINI via llvm-commits]

mehdi_amini added a subscriber: mehdi_amini.
mehdi_amini added a comment.

Keeping in mind that the inliner threshold is (AFAIK) a balance between code-size and performance. With this view, it "makes sense" to have a different cost for calls: they can trigger spilling around the call site and they may need to push args on the stack. Of course the same cost should be applied to the call that is removed in the caller.
I'm not saying that 25 is the best approximation, indeed I'd expect that the number of args to the call play a role.


Repository:
  rL LLVM

https://reviews.llvm.org/D24338