[llvm] r280888 - [XRay] ARM 32-bit no-Thumb support in LLVM

[Renato Golin via llvm-commits]

On 8 September 2016 at 14:54, Renato Golin <renato.golin at linaro.org> wrote:
> On 8 September 2016 at 01:19, Dean Michael Berris via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Author: dberris
>> Date: Wed Sep  7 19:19:04 2016
>> New Revision: 280888
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=280888&view=rev
>> Log:
>> [XRay] ARM 32-bit no-Thumb support in LLVM
>>
>> This is a port of XRay to ARM 32-bit, without Thumb support yet. The XRay instrumentation support is moving up to AsmPrinter.
>> This is one of 3 commits to different repositories of XRay ARM port. The other 2 are:
>>
>> 1. https://reviews.llvm.org/D23932 (Clang test)
>> 2. https://reviews.llvm.org/D23933 (compiler-rt)
>
> We're getting "Error: attempt to use an ARM instruction on a
> Thumb-only processor" errors on our Thumb buildbot.
>
> http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/4035/steps/build%20stage%201/logs/stdio
>
> I missed the lack of ARM support checks, but I tried to fix this in r280935.
>
> I'll let you know if it passes later.


Right, my fix didn't work, we need to test it appropriately before re-applying.

Can you revert all four patches, please?

cheers,
--renato