[PATCH] D24337: Fix the Thumb test for vfloat intrinsics

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 05:16:55 PDT 2016


jmolloy requested changes to this revision.
jmolloy added a comment.
This revision now requires changes to proceed.

Hi Pablo,

There are two changes here, and they should have been submitted separately and not in one phab review.

That said, they look simple enough to disentangle so I've reviewed them. The .code32 one LGTM. I have  a query about the other.

When submitting these, please ensure they are submitted as two separate commits.

James


================
Comment at: test/CodeGen/ARM/vfloatintrinsics.ll:322
@@ -321,3 +321,1 @@
 }
-; CHECK: test_v2f64.fabs:
-define %v2f64 @test_v2f64.fabs(%v2f64 %a) {
----------------
Why has this testcase been removed?


https://reviews.llvm.org/D24337





More information about the llvm-commits mailing list