[PATCH] D24229: [ELF] - Versionscript: do not treat non-wildcarded names as wildcards.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/ScriptParser.cpp:63
@@ -62,3 +62,3 @@
 
     // Quoted token.
     if (S.startswith("\"")) {
----------------
ruiu wrote:
> Please add a comment why we leave double quotes in a resulting token.
> 
>   // Quoted token. Note that double-quote characters are parts of a token
>   // because, in a glob match context, only unquoted tokens are interpreted
>   // as glob patterns. Double-quoted tokens are literal patterns in that context.
Done.

================
Comment at: test/ELF/version-script-extern-exact.s:7
@@ +6,3 @@
+# RUN:      extern \"C++\" {   \
+# RUN:         \"aaa*\";    \
+# RUN:   };                  \
----------------
ruiu wrote:
>   echo "FOO { global: extern \"C++\" \"aaa*\"; }; };" > %t.script
Done.


https://reviews.llvm.org/D24229