[PATCH] D24288: Don't reduce mul if the target doesn't support SSE2

Wei Mi via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 09:50:11 PDT 2016


wmi added inline comments.

================
Comment at: test/CodeGen/X86/pr30298.ll:1
@@ +1,2 @@
+; REQUIRES: asserts
+; RUN: llc -mtriple=i386-pc-linux-gnu -mattr=+sse < %s | FileCheck %s
----------------
mkuper wrote:
> I don't see why this test would require asserts. A copy/paste bug?
It doesn't need it. I do want the test to be effective even if the test doesn't enable assertion. And I think that is why you suggest me to give a positive check. Thanks! 

================
Comment at: test/CodeGen/X86/pr30298.ll:3
@@ +2,3 @@
+; RUN: llc -mtriple=i386-pc-linux-gnu -mattr=+sse < %s | FileCheck %s
+; CHECK-NOT: pmullw
+ at c = external global i32*, align 8
----------------
mkuper wrote:
> Please add a positive check for the code we do expect.
Ok. will add it.


Repository:
  rL LLVM

https://reviews.llvm.org/D24288





More information about the llvm-commits mailing list