[PATCH] D24267: [ELF] - Added support of --gdb-index command line option.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 09:03:13 PDT 2016


grimar marked 2 inline comments as done.
grimar added a comment.

In https://reviews.llvm.org/D24267#535243, @ruiu wrote:

> It is a very large patch that has almost no comment, so it is hard to read (I didn't read through till end.) Non-code part is as important as code. It really needs overview comments so that first-time readers of the code like me can get an idea what you are trying to do with the code and what your intention is. What is the expected output, and what kinds of inputs are used to create the desired output? Why do we need such output in the first place? You want to explain these kind of things in this patch like writing a blog article about this feature.


Yep, sorry for lack of comments. 
I am working on that, also going to try to simplify a little where possible before pushing an update. 
Hope to upload new version till the end of this week.


https://reviews.llvm.org/D24267





More information about the llvm-commits mailing list