[PATCH] D23118: [mips] Fix c.<cc>.<fmt> instruction definition.

[Zoran Jovanovic via llvm-commits]

zoran.jovanovic accepted this revision.
zoran.jovanovic added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: lib/Target/Mips/MicroMipsInstrFPU.td:168
@@ +167,3 @@
+                      InstrItinClass itin> {
+     def C_F_#NAME : MMRel, C_COND_FT<"f", TypeStr, RC, itin>,
+                     C_COND_FM_MM<fmt, 0>;
----------------
Nit: I do believe that MMRel is not necessary here.  It seems that instruction mapping is not used in this case.

================
Comment at: lib/Target/Mips/MicroMipsInstrFPU.td:211
@@ +210,3 @@
+  defm S_MM : FPSetccPats<MOVT_I_MM, MOVF_I_MM, (LI16_MM 1), FGR32Opnd>;
+  defm D32_MM : FPSetccPats<MOVT_I_MM, MOVF_I_MM, (LI16_MM 1), AFGR64Opnd>, FGR_32;
+
----------------
Nit: Line exceeds 80 characters.

================
Comment at: lib/Target/Mips/MipsCondMov.td:337
@@ +336,3 @@
+
+multiclass FPSelectPats<RegisterOperand RC, RegisterOperand RO, string Type, Instruction MOVT,
+                        Instruction MOVF> {
----------------
Nit: Line exceeds 80 characters.

================
Comment at: lib/Target/Mips/MipsFastISel.cpp:712
@@ -711,4 +711,3 @@
     emitInst(Mips::ADDiu, RegWithOne).addReg(Mips::ZERO).addImm(1);
-    emitInst(Opc).addReg(LeftReg).addReg(RightReg).addReg(
-        Mips::FCC0, RegState::ImplicitDefine);
+    emitInst(Opc).addReg(Mips::FCC0, RegState::Define).addReg(LeftReg).addReg(RightReg);
     emitInst(CondMovOpc, ResultReg)
----------------
Nit: Line exceeds 80 characters.


Repository:
  rL LLVM

https://reviews.llvm.org/D23118