[PATCH] D24256: [InstCombine][sse4a] Fix assertion failure caused by unsafe dyn_casts on the operands of extrq/extrqi intrinsic calls.

Andrea Di Biagio via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 03:51:10 PDT 2016


andreadb added a comment.

In https://reviews.llvm.org/D24256#535193, @RKSimon wrote:

> Thanks Andrea, does INSERTQI have a similar problem?


Possibly. We are currently running extensive tests. So far, the extrq is the only problematic one. I wouldn't be surprised if that happens with the INSERTQI though (I saw that there is similar code in there). I will run some experiments and I will let you know in case.
Would it be okay if in the meatime I commit this change?

Have a nice day,
Andrea


https://reviews.llvm.org/D24256





More information about the llvm-commits mailing list