[PATCH] D24279: [InstCombine] canonicalize vector select with constant vector condition to shuffle

[Sanjay Patel via llvm-commits]

spatel added inline comments.

================
Comment at: lib/Transforms/InstCombine/InstCombineSelect.cpp:968
@@ +967,3 @@
+    for (unsigned int i = 0; i != NumElts; ++i) {
+      Constant *Elt = CondC->getAggregateElement(i);
+      if (Elt->isOneValue()) {
----------------
majnemer wrote:
> Can't this return null?
Argh...yes. Let me concoct some tests from the last time I forgot about constant expressions. :)


https://reviews.llvm.org/D24279