[PATCH] D23646: Generalize strided store pattern in interleave access pass

Alina Sbirlea via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 15:37:54 PDT 2016


asbirlea added inline comments.

================
Comment at: lib/CodeGen/InterleavedAccessPass.cpp:400
@@ +399,3 @@
+  // Check that the range is aligned on this arch
+  // FIXME: Make this alignment verification process correct and complete.
+  /*
----------------
This is a part that I'm not sure is needed, and how to address it.

The goal was to check for the alignment of each of the strides, i.e. BaseStoreAddress + StartingIncrementInStride, for all stride [0, Factor).
The commented attempt has a series of problems and does not achieve this. Should this check exist and what's the correct way to handle it?


https://reviews.llvm.org/D23646





More information about the llvm-commits mailing list