[Patch] Break the Demangle -> Support dependency

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 13:42:15 PDT 2016


OK, I will drop the custom allocators for now.

Cheers,
Rafael


On 6 September 2016 at 16:30, Craig, Ben <ben.craig at codeaurora.org> wrote:
> I dislike how little malloc is called in the current code.  The current
> implementation puts many kilobytes of data on the stack. It's a bit stack
> overflow waiting to happen.
>
>
>
> On 9/6/2016 3:23 PM, Rafael EspĂ­ndola via llvm-commits wrote:
>>
>> On 6 September 2016 at 16:18, Reid Kleckner <rnk at google.com> wrote:
>>>
>>> Do we intend to make this demangler asynch signal safe, i.e. not call
>>> malloc
>>> at all? If so, I vote keep the custom allocator. If not, I'd say nuke it.
>>
>> Is that a requirement for the demangler in libcxxabi? Note that as it
>> is right now I think we would still call malloc in some cases (both
>> mallloc_alloc and arena::allocate).
>>
>> Cheers,
>> Rafael
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
> --
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
> Foundation Collaborative Project
>


More information about the llvm-commits mailing list