[PATCH] D23874: [asan] Reify ErrorNewDeleteSizeMismatch

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 11:42:14 PDT 2016


vitalybuka added inline comments.

================
Comment at: lib/asan/asan_errors.cc:105
@@ +104,3 @@
+  Report(
+      "ERROR: AddressSanitizer: new-delete-type-mismatch on %p in thread "
+      "T%d%s:\n",
----------------
is this clang-formatted?

================
Comment at: lib/asan/asan_errors.h:144
@@ -123,3 +143,3 @@
 
 struct ErrorDescription {
   ErrorKind kind;
----------------
Just asking: can we make it a "class" with private data and add
some

const ErrorStackOverflow* AsStackOverflow() {
  if (kind does not math)
    return nulltpr;
  return stack_overflow;
}

is this going to work for debugger?


https://reviews.llvm.org/D23874





More information about the llvm-commits mailing list