[PATCH] D23356: [DAG] Fix incorrect alignment of ext load.

Nirav Dave via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 11:31:16 PDT 2016


niravd added inline comments.

================
Comment at: test/CodeGen/AMDGPU/extload-align.ll:5
@@ +4,3 @@
+; DEBUG: {{^}}# Machine code for function extload_align:
+; DEBUG: mem:LD2[<unknown>]{{[^(]}}
+; DEBUG: {{^}}# End machine code for function extload_align.
----------------
hfinkel wrote:
> It is not obvious what you're checking here. Do you want to match the alignment? (or are you matching the lack of a non-default alignment)?
That's correct. I'm checking that the alignment is 2 and matching the underlying i16 load, not 4 matching the size of the extend value. I've added a comment to the test making this clearer. 


https://reviews.llvm.org/D23356





More information about the llvm-commits mailing list