[PATCH] D24014: [codeview] Add new directives to record inlined call site line info

[Reid Kleckner via llvm-commits]

rnk marked 2 inline comments as done.

================
Comment at: lib/MC/MCParser/AsmParser.cpp:3311
@@ +3310,3 @@
+  // IAFile IALine
+  if (parseIntToken(IAFile, "expected file id after 'inlined_at'") ||
+      parseIntToken(IALine, "expected line number after 'inlined_at'"))
----------------
majnemer wrote:
> Dow we want to validate using isValidFileNumber?
Yep, done.

================
Comment at: lib/MC/MCParser/AsmParser.cpp:3311
@@ +3310,3 @@
+  // IAFile IALine
+  if (parseIntToken(IAFile, "expected file id after 'inlined_at'") ||
+      parseIntToken(IALine, "expected line number after 'inlined_at'"))
----------------
rnk wrote:
> majnemer wrote:
> > Dow we want to validate using isValidFileNumber?
> Yep, done.
I added a bunch of diagnostics tests for this in cv-errors.s. It's not as good as clang -verify, but such is life.


https://reviews.llvm.org/D24014