[PATCH] D24118: [JumpThreading] Only write back branch-weight MDs for blocks that originally had PGO info

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 09:09:01 PDT 2016


anemet added inline comments.

================
Comment at: test/Transforms/JumpThreading/static-profile.ll:79
@@ +78,3 @@
+  %cond1 = icmp eq i32 %v, 1
+  br i1 %cond1, label %eq_1, label %check_2
+
----------------
davidxl wrote:
> Perhaps check threading happens here and this branch has no meta data 
> 
> CHECK: br .... check2_thread, .... label %check_2$
> CHECK-NEXT: check_2.thread:
Right!

Thanks for the review!


https://reviews.llvm.org/D24118





More information about the llvm-commits mailing list