[llvm] r280674 - [lit] Downgrade error to warning on gtest crashes during discovery.

Ahmed Bougacha via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 5 13:53:14 PDT 2016


Author: ab
Date: Mon Sep  5 15:53:14 2016
New Revision: 280674

URL: http://llvm.org/viewvc/llvm-project?rev=280674&view=rev
Log:
[lit] Downgrade error to warning on gtest crashes during discovery.

Lots of unittests started failing under asan after r280455.  It seems
they've been failing for a long time, but lit silently ignored them.

Downgrade the error so we can figure out what is going on.
Filed http://llvm.org/PR30285.

Modified:
    llvm/trunk/utils/lit/lit/formats/googletest.py

Modified: llvm/trunk/utils/lit/lit/formats/googletest.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/formats/googletest.py?rev=280674&r1=280673&r2=280674&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/formats/googletest.py (original)
+++ llvm/trunk/utils/lit/lit/formats/googletest.py Mon Sep  5 15:53:14 2016
@@ -37,8 +37,8 @@ class GoogleTest(TestFormat):
             lines = lines.split('\n')
         except Exception as exc:
             out = exc.output if isinstance(exc, subprocess.CalledProcessError) else ''
-            litConfig.error("unable to discover google-tests in %r: %s. Process output: %s"
-                            % (path, sys.exc_info()[1], out))
+            litConfig.warning("unable to discover google-tests in %r: %s. Process output: %s"
+                              % (path, sys.exc_info()[1], out))
             raise StopIteration
 
         nested_tests = []




More information about the llvm-commits mailing list