[PATCH] D23456: [Sparc] Leon Errata Fix Passes

Chris Dewhurst via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 5 05:54:26 PDT 2016


lero_chris added a comment.

Hi, The formatting changes that were *entirely* unrelated to the code updates have been removed. As part of the review process, I also removed all the inline ASM code,m as requested by James Knight. Otherwise, the changes are all specifically to do with the updated passes, except some very small changes to comments and formatting *entirely in and around code that has been changed as part of this update*.

This review really needs to be completed this Friday, so we really need all appropriate comments by then or these changes simply will not be able to be completed before I move to a different employer.

Please focus comments on breaking changes. If there are none, I need to get this code checked-in. Comments on code improvement must come later at this stage and there may be time for improvements later on if we can get this base-line checked-in.


Repository:
  rL LLVM

https://reviews.llvm.org/D23456





More information about the llvm-commits mailing list