[PATCH] D23456: [Sparc] Leon Errata Fix Passes

[Daniel Cederman via llvm-commits]

dcederman added a comment.

Hi,

It is hard to review this since you are mixing formatting changes, fixes to old passes, and new passes. I suggest that you update this revision so that it only contains the new passes (ReplaceSDIV, FixCALL, InsertNOPDoublePrecision, PreventRoundChange, InsertNOPsLoadStore) and their corresponding unit tests. The fixes to old passes and the formatting changes should be in separate patches.

You should also make sure that your code is actually used by your tests. You discovered now that IgnoreZeroFlag was not used anywhere and removed it, but what about FixCALL? Or ReplaceSDIV? Are they used?


Repository:
  rL LLVM

https://reviews.llvm.org/D23456