[llvm] r280447 - [PM] Add a unittest for invalidating module analyses with an SCC pass.
Chandler Carruth via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 4 01:55:12 PDT 2016
On Thu, Sep 1, 2016 at 6:24 PM Chandler Carruth via llvm-commits <
llvm-commits at lists.llvm.org> wrote:
> Author: chandlerc
> Date: Thu Sep 1 20:16:27 2016
> New Revision: 280447
> URL: http://llvm.org/viewvc/llvm-project?rev=280447&view=rev
> [PM] Add a unittest for invalidating module analyses with an SCC pass.
> This wasn't really well explicitly tested with a nice unittest before.
> It seems good to have reasonably broken out unittests for this kind of
> functionality as I'm workin go other invalidation features to make sure
> none of the existing ones regress.
> This still has too much duplicated code, I plan to factor that out in
> a subsequent commit to use common helpers for repeated parts of this.
Very sorry, this shouldn't have been committed. There is still debugging
code in it, and in fact the test only passes because of other bugs that I'm
fixing. I accidentally included this in a set of in-flight patches I landed
when I meant to queue it up behind the fixes to those other bugs. I've
reverted this in r280620 for now and will re-add the test without debug
code and when it will actually pass for the right reasons (and also in a
form where it won't pass for the wrong reasons!)
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits