[PATCH] D24118: [JumpThreading] Only write back branch-weight MDs for blocks that originally had PGO info

David Li via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 3 12:25:23 PDT 2016

davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

lgtm with some test change suggestion.

Comment at: test/Transforms/JumpThreading/static-profile.ll:79
@@ +78,3 @@
+  %cond1 = icmp eq i32 %v, 1
+  br i1 %cond1, label %eq_1, label %check_2
Perhaps check threading happens here and this branch has no meta data 

CHECK: br .... check2_thread, .... label %check_2$
CHECK-NEXT: check_2.thread:

Comment at: test/Transforms/JumpThreading/static-profile.ll:87
@@ +86,3 @@
+  %cond2 = icmp eq i32 %v, 2
+  br i1 %cond2, label %eq_2, label %check_3
similarly as above : check threading happens and no meta data is annotated here.


More information about the llvm-commits mailing list