[PATCH] D23808: [X86][SSE] Add lowering to cvttpd2dq/cvttps2dq for sitofp v2f64/2f32 to 2i32

[Elena Demikhovsky via llvm-commits]

delena added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:22223
@@ -22221,1 +22222,3 @@
 
+    if (IsSigned && N->getValueType(0) == MVT::v2i32) {
+      assert(Subtarget.hasSSE2() && "Requires at least SSE2!");
----------------
Why you do not call Lower_FP_TO_SINT ?

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:22225
@@ +22224,3 @@
+      assert(Subtarget.hasSSE2() && "Requires at least SSE2!");
+      SDValue Res = N->getOperand(0);
+      if (Res.getValueType() == MVT::v2f64) {
----------------
It is source, not Res. Please change variable name.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:22228
@@ +22227,3 @@
+        SDValue Idx = DAG.getIntPtrConstant(0, dl);
+        Res = DAG.getNode(X86ISD::CVTTPD2DQ, dl, MVT::v4i32, Res);
+        Res = DAG.getNode(ISD::EXTRACT_SUBVECTOR, dl, MVT::v2i32, Res, Idx);
----------------
Can you use FP_TO_SINT here?


Repository:
  rL LLVM

https://reviews.llvm.org/D23808