[PATCH] D23829: [ELF] - Use std::regex instead of hand written logic in elf::globMatch()

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 14:08:28 PDT 2016

grimar added a comment.

Thanks for review !

Comment at: ELF/Strings.cpp:51
@@ +50,3 @@
+// Takes multiple glob patterns and converts them into regex object.
+Regex elf::compileGlobPatterns(ArrayRef<StringRef> P) {
+  std::string T = "^(" + toRegex(P[0]);
ruiu wrote:
> Why `P`? I believe we usually use `V` or `Arr` for an ArrayRef.
Because Patterns. Actually choosed between V and P. Will switch to P then.


More information about the llvm-commits mailing list