[PATCH] D24205: Use od instead of hexdump.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 13:19:51 PDT 2016


ruiu created this revision.
ruiu added reviewers: grimar, tstellarAMD.
ruiu added a subscriber: llvm-commits.
Herald added a subscriber: wdng.

od is defined by POSIX and exists since version 1 AT&T Unix.
hexdump is not part of any standard as far as I know.
So od is a better choice than hexdump.

https://reviews.llvm.org/D24205

Files:
  test/ELF/oformat-binary.s

Index: test/ELF/oformat-binary.s
===================================================================
--- test/ELF/oformat-binary.s
+++ test/ELF/oformat-binary.s
@@ -2,14 +2,14 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
 
 # RUN: ld.lld -o %t.out %t --oformat binary
-# RUN: hexdump -C %t.out | FileCheck %s
-# CHECK: 00000000 90 11 22 00 00 00 00 00
+# RUN: od -t x1 -v %t.out | FileCheck %s
+# CHECK: 000000 90 11 22 00 00 00 00 00
 # CHECK-NOT: 00000010
 
 ## Check case when linkerscript is used.
 # RUN: echo "SECTIONS { . = 0x1000; }" > %t.script
 # RUN: ld.lld -o %t2.out --script %t.script %t --oformat binary
-# RUN: hexdump -C %t2.out | FileCheck %s
+# RUN: od -t x1 -v %t2.out | FileCheck %s
 
 # RUN: not ld.lld -o %t3.out %t --oformat foo 2>&1 \
 # RUN:   | FileCheck %s --check-prefix ERR


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24205.70217.patch
Type: text/x-patch
Size: 830 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160902/0f13040e/attachment.bin>


More information about the llvm-commits mailing list