[lld] r280529 - Rename UnresolvedPolicy::Error -> UnresolvedPolicy::ReportError.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 12:36:29 PDT 2016


Author: ruiu
Date: Fri Sep  2 14:36:29 2016
New Revision: 280529

URL: http://llvm.org/viewvc/llvm-project?rev=280529&view=rev
Log:
Rename UnresolvedPolicy::Error -> UnresolvedPolicy::ReportError.

"Error" looks like it is indicating a parse error. "Error" actually
instructs the later process to report an error if there's an error
condition. Thus the new name.

Modified:
    lld/trunk/ELF/Config.h
    lld/trunk/ELF/Driver.cpp

Modified: lld/trunk/ELF/Config.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Config.h?rev=280529&r1=280528&r2=280529&view=diff
==============================================================================
--- lld/trunk/ELF/Config.h (original)
+++ lld/trunk/ELF/Config.h Fri Sep  2 14:36:29 2016
@@ -40,7 +40,7 @@ enum class DiscardPolicy { Default, All,
 enum class StripPolicy { None, All, Debug };
 
 // For --unresolved-symbols.
-enum class UnresolvedPolicy { NoUndef, Error, Warn, Ignore };
+enum class UnresolvedPolicy { NoUndef, ReportError, Warn, Ignore };
 
 struct SymbolVersion {
   llvm::StringRef Name;

Modified: lld/trunk/ELF/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=280529&r1=280528&r2=280529&view=diff
==============================================================================
--- lld/trunk/ELF/Driver.cpp (original)
+++ lld/trunk/ELF/Driver.cpp Fri Sep  2 14:36:29 2016
@@ -328,10 +328,10 @@ static UnresolvedPolicy getUnresolvedSym
     if (S == "ignore-all" || S == "ignore-in-object-files")
       return UnresolvedPolicy::Ignore;
     if (S == "ignore-in-shared-libs" || S == "report-all")
-      return UnresolvedPolicy::Error;
+      return UnresolvedPolicy::ReportError;
     error("unknown --unresolved-symbols value: " + S);
   }
-  return UnresolvedPolicy::Error;
+  return UnresolvedPolicy::ReportError;
 }
 
 static bool isOutputFormatBinary(opt::InputArgList &Args) {




More information about the llvm-commits mailing list