[PATCH] D23766: DebugInfo: use strongly typed enum for debug info flags
Victor Leschuk via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 2 11:23:45 PDT 2016
If you try to store value which is larger than FlagLargest it will
trigger assert() in BitmapEnum. So these tests look invalid for me now.
On 09/02/2016 06:36 PM, David Blaikie wrote:
> Are those tests actually invalid now? You can still stuff non-flag
> values into the flag with a static cast, so perhaps we should keep the
> test around in that form?
> On Thu, Sep 1, 2016 at 11:51 PM Victor <vleschuk at gmail.com
> <mailto:vleschuk at gmail.com>> wrote:
> vleschuk updated this revision to Diff 70135.
> vleschuk added a comment.
> Removed few deprecated tests which don't make sense with new type
> for flags.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits