[llvm] r280442 - [CFGPrinter] Display branch weight on the edges

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 10:46:23 PDT 2016

Adam Nemet <anemet at apple.com> writes:
>> On Sep 1, 2016, at 11:01 PM, Justin Bogner <mail at justinbogner.com> wrote:
>> Adam Nemet via llvm-commits <llvm-commits at lists.llvm.org
>>> While with -view-cfg-only you can see the underlying branch weights:
>>> https://reviews.llvm.org/F2392296 <https://reviews.llvm.org/F2392296>
>>> Reviewers: dexonsmith, bogner, davidxl
>> When committing, please edit "Reviewers" to accurately reflect people
>> who reviewed the patch, or just rip it out completely. The change does
>> LGTM, but I find the way that phab/arc/whatever blindly lists people who
>> happened to be CC'd as reviewers quite misleading.
> Yeah, I found that confusing in the past as well but I guess I’ve
> gotten used to interpreting it the right way.  Unfortunately anybody
> using arcanist to manage Phab will have this problem.  Do you want to
> perhaps bring this is up on llvm-dev to try to get a consensus.  Or
> maybe this is something that can be adjusted on the server side by
> Manuel?

Oh, I've brought it up before. It's llvm.org/PR28300.

More information about the llvm-commits mailing list