[PATCH] D24070: Setting fp trapping mode and denormal type

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 09:57:59 PDT 2016

echristo accepted this revision.
echristo added a comment.

One nit, then OK.



Comment at: lib/Target/TargetMachine.cpp:94
@@ +93,3 @@
+/// and false otherwise.
+bool TargetMachine::haveAllFunctionsAttribute(const Module &M, StringRef Attr,
+                                              StringRef Value) {
Bike shed:

No real reason to have this here, just go ahead an have it be a static function in the arm asm printer for now.


More information about the llvm-commits mailing list