[PATCH] D24160: llvm-objdump: Implement --start-address and --stop-address
email@example.com via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 2 09:37:30 PDT 2016
khemant added inline comments.
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1529
@@ -1494,1 +1528,3 @@
+ if ((SectionAddr + addr) < StartAddress)
+ goto skip_print_rel;
// Stop when rel_cur's address is past the current instruction.
> Why use goto rather than wrap the bit in the if condition?
Yea. Even using this goto should have been merged with above goto. I will invert the if condition for both of those cases.
More information about the llvm-commits