[PATCH] D23829: [ELF] - Use std::regex instead of hand written logic in elf::globMatch()

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 09:22:05 PDT 2016

grimar added inline comments.

Comment at: ELF/Strings.cpp:42
@@ -44,3 +41,3 @@
+      T += F;
     S = S.substr(1);
ruiu wrote:
> Are you sure? What will happen if you have this?
>   SECTIONS { .text : { "foo(bar*).o"( .text ); } }
> where "foo(bar*).o" is an actual file name.
I did not say it is not possible. I meant it is so unusual that we even do not have testcases covering that. And sutuation is unlikely to happen, that is why I suggested to prepare testcases and separate patch for that.
>From your comments it seems you would like to see it in this patch. Ok, I'll do that.


More information about the llvm-commits mailing list