[PATCH] D24176: Remove temoprary files.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 08:29:33 PDT 2016

rnk added inline comments.

Comment at: COFF/DriverUtils.cpp:585
@@ -570,3 +584,3 @@
-  return check(MemoryBuffer::getFile(Path), "could not open " + Path);
+  return check(MemoryBuffer::getFile(File.Path), "could not open " + File.Path);
I think the explanation is that MemoryBuffer only uses MapViewOfFile when shouldUseMmap returns true (if the file is small or its size is a multiple of 4K and RequiresNullTerminator is set). I suspect if you arrange for it to return true, then this removal will fail.


More information about the llvm-commits mailing list