[PATCH] D24143: Fix incorrect folding of an ordered fcmp with a vector of all NaN.

Andrea Di Biagio via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 07:43:58 PDT 2016

andreadb added a comment.

In https://reviews.llvm.org/D24143#532881, @spatel wrote:

> Given the number of times we duplicate this line in this function, we could make this parallel the code in SimplifyICmpInst:
>   Type *RetTy = GetCompareTy(LHS); // at the top of the function
>   getFalse(RetTy); // everywhere below

Thanks Sanjay!

I agree that we can avoid the code duplication (even for the case where 'true' is returned).
I commit this for now and then do the cleanup on a separate NFC patch.



More information about the llvm-commits mailing list