[PATCH] D23456: [Sparc] Leon Errata Fix Passes

Daniel Cederman via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 04:38:03 PDT 2016

dcederman requested changes to this revision.
dcederman added a comment.
This revision now requires changes to proceed.

One of the passes generates this instruction, "wr %g0, 1, %psr", which tells me that it has not been tested. You should make sure that the errata fixes do not break the resulting program. I would recommend reading up on the psr register and how it is used before attempting to modify it.

I have plenty of other comments, but you really should test the code before submitting it for review.



More information about the llvm-commits mailing list