[PATCH] D23829: [ELF] - Use std::regex instead of hand written logic in elf::globMatch()

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 02:02:12 PDT 2016

grimar added inline comments.

Comment at: ELF/LinkerScript.h:101
@@ -98,1 +100,3 @@
+      : BaseCommand(InputSectionKind),
+        FilePattern(compileGlobPattern(FilePattern)) {}
   static bool classof(const BaseCommand *C);
ruiu wrote:
> Please do not use the implicit conversion from an object of type T to ArrayRef<T>. That confused me. Add `{}` around `FilePattern`. You also want to rename `compileGlobPatterns` since now it takes not a single glob pattern but many patterns.
Ok, I just was unsure what is the best way to avoid that. Was thinking about separate method for single pattern compilation, unfortunately it needs to be exported so rejected that way.
Approach with {} should work and looks evident enough, will use it.


More information about the llvm-commits mailing list