[PATCH] D24164: Remove debug info when hoisting instruction from then/else branch.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 19:49:56 PDT 2016

dblaikie added a comment.

I would worry that this might produce a worse experience for a sanitizer user, for example - but I'm not sure. (the sanitizer user won't have any trail back to why the store in this example is happening - granted, the way the code currently works, they may be told the store is happening in the wrong branch, which isn't great either)

Would mind getting Eric, Chandler, and/or Kostya's perspective on this.

As for the mechanics: might want to sure-up the CHECK lines to actually trace the lines back to the instructions - depending on the ordering of the DILocations being emitted is probably a bit too brittle.


More information about the llvm-commits mailing list