[PATCH] D24171: Refactor LICM to expose canSinkOrHoistInst to LoopSink pass.

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 19:26:23 PDT 2016

On Thu, Sep 1, 2016 at 7:15 PM, Dehao Chen <danielcdh at gmail.com> wrote:
> danielcdh reopened this revision.
> danielcdh added a comment.
> This revision is now accepted and ready to land.
> Oops, I saw people approving their own patch and commit without approval from others and thought it's common practice. If that's not the case, I apologize.


All changes require review. Small changes can be reviewed after commit.

One problem is that Chandler's comment (asking for further review of
the split patch) was somehow missed. Another thing is if technically
the split out NFC patch is considered part of the original patch, then
it will also need an explicit lgtm (as the pre-commit review has


> Revert r280429 and r280425 in r280453, and will reopen https://reviews.llvm.org/D24168#532233 to address comments.
> Repository:
>   rL LLVM
> https://reviews.llvm.org/D24171

More information about the llvm-commits mailing list