[PATCH] D24168: Refactor LICM pass in preparation for LoopSink pass.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 17:29:05 PDT 2016

chandlerc added a comment.

In https://reviews.llvm.org/D24168#532233, @danielcdh wrote:

> This is an obvious change, I will commit it without review.

So, in the code review where I asked for the change, I mentioned I had some comments that should be attached to it. So that might signify that it isn't fully obvious...

And once you *ask* for a pre-commit review, it seem much more polite to see it through. Comments inbound shortly.


More information about the llvm-commits mailing list