[PATCH] D24135: [ELF] Linkerscript: support ABSOLUTE keyword in symbol assignment expression

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 15:33:03 PDT 2016

ruiu added inline comments.

Comment at: ELF/LinkerScript.cpp:286-287
@@ +285,4 @@
+    if (Cmd->ForceAbsolute) {
+      replaceBody<DefinedRegular<ELFT>>(S, Cmd->Name,
+                                        static_cast<uint8_t>(S->Visibility));
+      Body->Value = Cmd->Expression(Sec->getVA() + Off);
evgeny777 wrote:
> ruiu wrote:
> > Why do you have to replace a symbol here only when it is an absolute symbol?
> Because it is initially created as synthetic in addSynthetic()
Why don't you create that as a DefinedRegular symbol from the beginning?



More information about the llvm-commits mailing list