[PATCH] D24151: [Legalizer] Don't throw away false low half for GT/LT SETCC

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 14:27:35 PDT 2016


mkuper added inline comments.

================
Comment at: test/CodeGen/X86/pr29170.ll:10
@@ +9,3 @@
+; CHECK: cmpl
+; CHECL: sbbl
+define i32 @main() {
----------------
spatel wrote:
> 'CHECL' - use utils/update_test_checks.py to avoid human error? :)
Yikes, thanks!
(I intentionally didn't use update_test_checks, since I wanted a fairly "loose" test. But should have double checked the checks!)


https://reviews.llvm.org/D24151





More information about the llvm-commits mailing list