[PATCH] D23879: Properly handle live subranges when moving instructions

[Quentin Colombet via llvm-commits]

qcolombet added a comment.

Hi Krzysztof,

I am not seeing a unitest in unittests/MI/LiveIntervalTest.cpp like Matthias suggested.
Also, could you use "opt -instnamer" on the ll test cases.

Other than that, LGTM just one nitpick, see inlined comment.

Cheers,
-Quentin


================
Comment at: lib/CodeGen/LiveIntervalAnalysis.cpp:1004
@@ -999,3 +1003,3 @@
   /// to NewIdx (OldIdx < NewIdx).
-  void handleMoveDown(LiveRange &LR) {
+  void handleMoveDown(LiveRange &LR, unsigned Reg, LaneBitmask LaneMask) {
     LiveRange::iterator E = LR.end();
----------------
Document the extra parameters.


Repository:
  rL LLVM

https://reviews.llvm.org/D23879