[PATCH] D24120: [ELF] Do not omit debug sections when computing build-id

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 15:23:26 PDT 2016

phosek added inline comments.

Comment at: ELF/Writer.cpp:1328
@@ -1337,2 +1327,3 @@
+  Regions.push_back({Start, End});
ruiu wrote:
> Please simplify `writeBuildId` so that it takes just a uint8_t pointer and size instead of an array of arrays.
I've changed it to use `ArrayRef<uint8_t>`, do you prefer to use pointer and size instead?


More information about the llvm-commits mailing list