[PATCH] D23897: [SelectionDAG] Generate vector_shuffle nodes for undersized result vector sizes

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 13:25:15 PDT 2016

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - with one minor.

Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:3090
@@ +3089,3 @@
+    for (unsigned i = MaskNumElts; i != PaddedMaskNumElts; ++i)
+      MappedOps.push_back(-1);
Possibly remove this, initialize as MappedOps(PaddedMaskNumElts, -1) and then just insert MappedOps[i] = Idx in the readjustment loop.


More information about the llvm-commits mailing list