[PATCH] D24139: [ELF] - Fix for: bug 30237 - lld does not implement -f option

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 13:25:44 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/OutputSections.cpp:653
@@ -652,1 +652,3 @@
   // DynStrTab and doing this here allows this function to set DT_STRSZ.
+  for (StringRef Aux : Config->AuxiliaryList)
+    Add({DT_AUXILIARY, Out<ELFT>::DynStrTab->addString(Aux)});
----------------
nit: Since the scope is just two lines, I'd give even shorter name, say S.


https://reviews.llvm.org/D24139





More information about the llvm-commits mailing list