[llvm] r280410 - Fix the ASan fuse-lld.cc test after LLD r280012

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 13:29:00 PDT 2016

Author: rnk
Date: Thu Sep  1 15:28:59 2016
New Revision: 280410

URL: http://llvm.org/viewvc/llvm-project?rev=280410&view=rev
Fix the ASan fuse-lld.cc test after LLD r280012

With that change, images built with 'lld-link /debug' always have a
debug directory. If no PDB filename was passed on the command line, then
the filename in the executable is empty.

PDB information would never work anyway if the PDB file name is empty,
so go ahead and try DWARF in that case.


Modified: llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp?rev=280410&r1=280409&r2=280410&view=diff
--- llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp (original)
+++ llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp Thu Sep  1 15:28:59 2016
@@ -394,7 +394,7 @@ LLVMSymbolizer::getOrCreateModuleInfo(co
     const codeview::DebugInfo *DebugInfo;
     StringRef PDBFileName;
     auto EC = CoffObject->getDebugPDBInfo(DebugInfo, PDBFileName);
-    if (!EC && DebugInfo != nullptr) {
+    if (!EC && DebugInfo != nullptr && !PDBFileName.empty()) {
       using namespace pdb;
       std::unique_ptr<IPDBSession> Session;
       if (auto Err = loadDataForEXE(PDB_ReaderType::DIA,

More information about the llvm-commits mailing list