[PATCH] D23933: [XRay] ARM 32-bit no-Thumb support in compiler-rt

Serge Rogatch via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 11:57:50 PDT 2016

rSerge marked an inline comment as done.

Comment at: lib/sanitizer_common/scripts/gen_dynamic_list.py:54
@@ -52,3 +53,3 @@
   # On PowerPC, nm prints function descriptors from .data section.
-  if os.uname()[4] in ["powerpc", "ppc64"]:
+  if platform.uname()[4] in ["powerpc", "ppc64"]:
     func_symbols += ['D']
Tested on Ubuntu x86_64.

Comment at: lib/xray/xray_inmemory_log.cc:188
@@ +187,3 @@
+#elif defined(__arm__)
+    // There is no instruction like RDTSCP in user mode on ARM. So we use
+    //   clock_gettime() which gives the result in nanoseconds. To get the
rengolin wrote:
> Ah, I see. I didn't know RDTSCP had a fixed frequency. In that case, a comment explaining it would be most welcome.


More information about the llvm-commits mailing list